git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] Add config variable to set HTML path for git-help --web

From
Chris Webb <chris@arachsys.com>
Date
Jun 27, 2012, 20:55 UTC
Message-ID
<8d3c71d21710c66e4d5560cec958552b69a22338.1340830514.git.chris@arachsys.com>
In-Reply-To
<20120627205459.GC11498@arachsys.com>

If set in git-config, help.htmlpath overrides system_path(GIT_HTML_PATH) which was compiled in. This allows users to repoint system-wide git at their own copy of the documentation without recompiling.

Signed-off-by: Chris Webb <chris@arachsys.com>
---
 builtin/help.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/builtin/help.c b/builtin/help.c
index 8f9cd60..b467db2 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -34,6 +34,8 @@ enum help_format {
 	HELP_FORMAT_WEB
 };
 
+static char *html_path = NULL;
+
 static int show_all = 0;
 static unsigned int colopts;
 static enum help_format help_format = HELP_FORMAT_NONE;
@@ -265,6 +267,12 @@ static int git_help_config(const char *var, const char *value, void *cb)
 		help_format = parse_help_format(value);
 		return 0;
 	}
+	if (!strcmp(var, "help.htmlpath")) {
+		if (!value)
+			return config_error_nonbool(var);
+		html_path = xstrdup(value);
+		return 0;
+	}
 	if (!strcmp(var, "man.viewer")) {
 		if (!value)
 			return config_error_nonbool(var);
@@ -387,7 +395,8 @@ static void show_info_page(const char *git_cmd)
 static void get_html_page_path(struct strbuf *page_path, const char *page)
 {
 	struct stat st;
-	const char *html_path = system_path(GIT_HTML_PATH);
+	if (!html_path)
+		html_path = system_path(GIT_HTML_PATH);
 
 	/* Check that we have a git documentation directory. */
 	if (stat(mkpath("%s/git.html", html_path), &st)
-- 
1.7.10
Previous: Chris WebbNext: Chris Webb
Message 2 of 15 in “A handful of help-related patches”
  1. Chris WebbJun 27, 2012
  2. 1/3 Add config variable to set HTML path for git-help --webChris Webb, Jun 27, 2012
  3. 2/3 Allow help.htmlpath to be an http: URLChris Webb, Jun 27, 2012
  4. Jeff KingJun 27, 2012
  5. Chris WebbJun 27, 2012
  6. Junio C HamanoJun 27, 2012
  7. Chris WebbJun 27, 2012
  8. Jeff KingJun 27, 2012
  9. Chris WebbJun 27, 2012
  10. Jeff KingJun 27, 2012
  11. Junio C HamanoJun 28, 2012
  12. Chris WebbJun 28, 2012
  13. Jeff KingJun 28, 2012
  14. Chris WebbJun 28, 2012
  15. 3/3 Add a help format 'usage' to provide brief command usageChris Webb, Jun 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.