git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL

From
Chris Webb <chris@arachsys.com>
Date
Jun 28, 2012, 06:56 UTC
Message-ID
<20120628065623.GB1742@arachsys.com>
In-Reply-To
<7vwr2s5f9v.fsf@alter.siamese.dyndns.org>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> On Wed, Jun 27, 2012 at 11:19:39PM +0100, Chris Webb wrote:
> 
> > How about only testing for a git documentation directory if both
> > help.htmlpath isn't set (so we're using the compiled-in version) and the
> > compiled-in version doesn't contain ://?
> 
> That just seems needlessly complex. Why not just check for "://" and be
> done?
[...]
Show 5 quoted lines
> So one solution would be to simply remove the check entirely. It was a
> slight nicety in some situations, but expanding the definition of the
> HTML path to include full URLs means we can no longer accurately
> determine what exists and what does not. So we can just stop trying and
> let the browser handle it completely.
Junio C Hamano <gitster@pobox.com> writes:
> This, and "://", both sound sensible.

I have no real preference between any of the suggestions so far: they'd all be completely fine with me. Peff's :// test for a URL is much better than my http: prefix, so should replace the latter if we need a test at all, but apart from that I don't mind at all.

Okay, I'll re-send now the :// version I did in response to Peff's first email purely on the basis that it doesn't change the behaviour at all for existing users who don't set htmlpath at all, plus it's already sat in my reflog!

However, if you'd both prefer a version in which I just take the check out altogether, let me know and I'll spin that instead.

Cheers,
Chris.
Previous: Junio C HamanoNext: Jeff King
Message 12 of 15 in “A handful of help-related patches”
  1. Chris WebbJun 27, 2012
  2. 1/3 Add config variable to set HTML path for git-help --webChris Webb, Jun 27, 2012
  3. 2/3 Allow help.htmlpath to be an http: URLChris Webb, Jun 27, 2012
  4. Jeff KingJun 27, 2012
  5. Chris WebbJun 27, 2012
  6. Junio C HamanoJun 27, 2012
  7. Chris WebbJun 27, 2012
  8. Jeff KingJun 27, 2012
  9. Chris WebbJun 27, 2012
  10. Jeff KingJun 27, 2012
  11. Junio C HamanoJun 28, 2012
  12. Chris WebbJun 28, 2012
  13. Jeff KingJun 28, 2012
  14. Chris WebbJun 28, 2012
  15. 3/3 Add a help format 'usage' to provide brief command usageChris Webb, Jun 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.