Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL

From: Chris Webb <chris@arachsys.com>
Date: Jun 27, 2012, 21:12 UTC
Message-ID: <20120627211219.GD11498@arachsys.com>
In-Reply-To: <20120627210502.GB2292@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> >  	/* Check that we have a git documentation directory. */
> > -	if (stat(mkpath("%s/git.html", html_path), &st)
> > -	    || !S_ISREG(st.st_mode))
> > -		die(_("'%s': not a documentation directory."), html_path);
> > +	if (prefixcmp(html_path, "http:")) {
> > +		if (stat(mkpath("%s/git.html", html_path), &st)
> > +				|| !S_ISREG(st.st_mode))
> > +			die("'%s': not a documentation directory.", html_path);
> > +	}
> 
> I'd rather not tie this directly to http. Is there any reason not to
> allow https, for example? Can we maybe just look for strstr("://")
> instead? That's the same magic we use to differentiate URLs from paths
> when looking for repositories.

Thanks, that's a much better heuristic! I'll use !strstr(html_path, "://") in a re-roll. You're quite right, this ought to also allow https://, ftp://, etc.

Best wishes,

Chris.