Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL

From

Junio C Hamano <gitster@pobox.com>

Date

Jun 28, 2012, 02:41 UTC

Message-ID

<7vwr2s5f9v.fsf@alter.siamese.dyndns.org>

In-Reply-To

<20120627225248.GB27566@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So one solution would be to simply remove the check entirely. It was a
> slight nicety in some situations, but expanding the definition of the
> HTML path to include full URLs means we can no longer accurately
> determine what exists and what does not. So we can just stop trying and
> let the browser handle it completely.

This, and "://", both sound sensible.

> Another option would be to introduce a new "net" type of help format
> which accepts a URL instead of a path. That would leave the existing
> code-path untouched. But it does seem needlessly complex, as it would do
> more or less the same thing as the "html" format.

Thanks.