Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL

From: Jeff King <peff@peff.net>
Date: Jun 27, 2012, 21:05 UTC
Message-ID: <20120627210502.GB2292@sigill.intra.peff.net>
In-Reply-To: <233b27a14d16a2a1cb38b9f3e07a3a79b09a3256.1340830514.git.chris@arachsys.com>

On Wed, Jun 27, 2012 at 09:55:13PM +0100, Chris Webb wrote:

Show 9 quoted lines

> Setting this to a URL prefix instead of a path to a local directory allows
> git-help --web to work even when HTML docs aren't locally installed, by
> pointing the browser at a copy accessible on the web. For example,
> 
>     [help]
>       format = html
>       htmlpath = http://git-scm.com/docs
> 
> will use the publicly available documentation on the git homepage.

Nice.

Show 9 quoted lines

>  	/* Check that we have a git documentation directory. */
> -	if (stat(mkpath("%s/git.html", html_path), &st)
> -	    || !S_ISREG(st.st_mode))
> -		die(_("'%s': not a documentation directory."), html_path);
> +	if (prefixcmp(html_path, "http:")) {
> +		if (stat(mkpath("%s/git.html", html_path), &st)
> +				|| !S_ISREG(st.st_mode))
> +			die("'%s': not a documentation directory.", html_path);
> +	}

I'd rather not tie this directly to http. Is there any reason not to allow https, for example? Can we maybe just look for strstr("://") instead? That's the same magic we use to differentiate URLs from paths when looking for repositories.

-Peff