Re: [PATCH] gitweb: use decode_utf8 directly

From: Alexandre Julliard <julliard@winehq.org>
Date: Jun 1, 2007, 13:45 UTC
Message-ID: <87zm3ju6tg.fsf@wine.dyndns.org>
In-Reply-To: <7vsladzp29.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 5 quoted lines

> I would say that the patch is an improvement from the current
> code so it should hit 'master'; I was a bit busy lately and then
> am sick, and also we are post -rc1 freeze now and I was being
> cautious, just in case some nacks from more informed parties
> arrive late.

Sorry for the late nack, but it turns out that this patch breaks diff output on the Wine server for files that are not utf-8.

The cause is apparently that decode_utf8() returns undef for invalid sequences instead of substituting a replacement char like decode("utf8") does.

That may be considered an Encode bug since we are running a fairly old version (1.99, coming with Debian 3.1), but I'd rather not upgrade perl on the server. Could the patch be reverted, or done differently?

-- 
Alexandre Julliard
julliard@winehq.org