Re: [PATCH] gitweb: use decode_utf8 directly

From: Junio C Hamano <junkio@cox.net>
Date: Jun 1, 2007, 20:00 UTC
Message-ID: <7vbqfzzbq8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200706012247.57273.ismail@pardus.org.tr>

Ismail Dönmez <ismail@pardus.org.tr> writes:

Show 13 quoted lines

> On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:
>> Alexandre Julliard <julliard@winehq.org> writes:
>> > Sorry for the late nack, but it turns out that this patch breaks diff
>> > output on the Wine server for files that are not utf-8.
>> >
>> > The cause is apparently that decode_utf8() returns undef for invalid
>> > sequences instead of substituting a replacement char like
>> > decode("utf8") does.
>>
>> Thanks for noticing.  Will revert.
>
> Why are reverting a correct bugfix? :( He's at most using outdated software. 
> *sigh*

I would assume that on top of a revert, with an additional

	return $str if is_utf8($str);

to to_utf8() you should be able to fix both installations that has old or new Encode.pm?