Re: [PATCH] gitweb: use decode_utf8 directly
- From
- Alexandre Julliard <julliard@winehq.org>
- Date
- Jun 1, 2007, 16:51 UTC
- Message-ID
- <87ejkvty7k.fsf@wine.dyndns.org>
- In-Reply-To
- <200706011650.10650.ismail@pardus.org.tr>
Ismail Dönmez <ismail@pardus.org.tr> writes:
> Sorry but thats too old. Of course I am not the maintainer of GIT so its not > for me to decide but well as David Woodhouse puts it, please join us in 21st > century and start using UTF-8.
That's not very helpful. There can be many valid reasons for not using utf-8, in our case compatibility with Windows tools is the main reason. And even if we were to convert all our files today, it wouldn't help when browsing older versions.
I'm not asking gitweb to magically guess the encoding of the files, I'm happy with it replacing invalid sequences with some substitution char, like it did before 1.5.2. But now it is deleting whole lines from the diff, without any indication that something went wrong. That's not an improvement IMNSHO.
-- Alexandre Julliard julliard@winehq.org