Re: [PATCH] gitweb: use decode_utf8 directly
- From
- Ismail Dönmez <ismail@pardus.org.tr>
- Date
- Jun 1, 2007, 19:47 UTC
- Message-ID
- <200706012247.57273.ismail@pardus.org.tr>
- In-Reply-To
- <7vr6ovzcgr.fsf@assigned-by-dhcp.cox.net>
On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:
Show 9 quoted lines
> Alexandre Julliard <julliard@winehq.org> writes:
> > Sorry for the late nack, but it turns out that this patch breaks diff
> > output on the Wine server for files that are not utf-8.
> >
> > The cause is apparently that decode_utf8() returns undef for invalid
> > sequences instead of substituting a replacement char like
> > decode("utf8") does.
>
> Thanks for noticing. Will revert.Why are reverting a correct bugfix? :( He's at most using outdated software. *sigh*
/ismail
-- Perfect is the enemy of good