Re: [PATCH] gitweb: use decode_utf8 directly
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 3, 2007, 19:26 UTC
- Message-ID
- <7vsladzp29.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200705032222.37387.ismail@pardus.org.tr>
Ismail Dönmez <ismail@pardus.org.tr> writes:
Show 6 quoted lines
>> But at the same time I wonder why should the callers be feeding >> an already decoded string to to_utf8(). It might be that some >> callers needs fixing. > > Is the patch OK do you want more investigation? Asking because its still not > in git.git.
I would say that the patch is an improvement from the current code so it should hit 'master'; I was a bit busy lately and then am sick, and also we are post -rc1 freeze now and I was being cautious, just in case some nacks from more informed parties arrive late.