Re: Interpreting EDITOR/VISUAL environment variables.

From: David Kastrup <dak@gnu.org>
Date: Aug 2, 2007, 10:31 UTC
Message-ID: <86fy32kz2a.fsf@lola.quinscape.zz>
In-Reply-To: <20070802101056.GA31182@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

Show 5 quoted lines

> David Kastrup <dak@gnu.org> wrote:
>> a) Using system and shell-quoting the filename.  Advantage: one can
>> set EDITOR='"/home/dak/My Programs/editor"' and have it work.
>> Disadvantage: shell-quoting a file name seems shell- and
>> system-dependent.

Actually I was talking C here, and the editor is never called from C in git but rather from the shell. So this problem is a non-problem for us.

Show 6 quoted lines

> What about this instead of quoting the argument?
>
>     sh -c '$EDITOR "$1" "$2"' editor +5 /path/to/file
>
> (i.e. for C execvp("/bin/sh", "-c", "$EDITOR \"$1\" \"$2\"", "editor",
>     "+5", "/path/to/file"))

It suffers from the fault that it does not work as far as I can see. -c does not set the positional parameters.

-- 
David Kastrup