Re: [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2007, 23:18 UTC
Message-ID: <7vy7gu3kuh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <85ejimrjb2.fsf@lola.goethe.zz>

David Kastrup <dak@gnu.org> writes:

Show 8 quoted lines

> David Kastrup <dak@gnu.org> writes:
>
>> The previous code only allowed specifying a single executable rather
>> than a complete command like "emacsclient --alternate-editor vi" in
>
> Oops, won't apply cleanly.  I found that I had already made a
> different (trivial) patch previously.  Let me try again and fold that
> patch in manually.

It is not just "won't apply". What if GIT_DIR had spaces (which is fine) and single-quotes in it? Wouldn't it percolate down to $@ because it becomes the leading directory of the temporary file name? And you quote '"$@"' and eval it, now what happens?