Re: Interpreting EDITOR/VISUAL environment variables.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2007, 19:53 UTC
Message-ID: <7v7iof3uc5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <85r6mnrs1z.fsf@lola.goethe.zz>

David Kastrup <dak@gnu.org> writes:

Show 8 quoted lines

> Well, I just checked the behavior with "less", "more", "mail" and
> "mailx", quite traditional commands that would not have a reason to
> complicate things by using "system" and quoting instead of exec.
> ...
> It turns out all three contestants still in the race apparently do a).
> If nobody has a sensible idea how to shell-quote generally enough...
> Under Unix, one has the option of using "..." and quoting the three of
> "$\ with \ or using '...' and replacing every contained ' with '\''.

Our scripts and C-level both tend to prefer using '\'' for its simplicity (this also applies to rare case the user wants to unquote it by hand). Because it now is all in git-sh-setup, it should be reasonably straightforward to implement the quoting of the temporary file name and drop dq around ${EDITOR-VISUAL}.

Please make it so.