Re: Shell script cleanups/style changes?

From: David Kastrup <dak@gnu.org>
Date: Aug 3, 2007, 06:06 UTC
Message-ID: <85lkctw3sl.fsf@lola.goethe.zz>
In-Reply-To: <7vabt9sasl.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> David Kastrup <dak@gnu.org> writes:
>
>>> I happen to feel ${parameter#word} is more esoteric than $(cmd).
>>> If a system does not even do the latter, then avoiding the
>>> former to help such a system is a futile effort.
>>
>> The situation is that we currently don't avoid the former.  Robert
>> said that he had prepared a patch that would do so.
>> ...
>> But "only a little bit of ${parameter#word}, please" seems pointless.
>
> Absolutely.  And we started to adopt #/% substititions some time
> ago.  Undoing them just feels going backwards, and we need to judge
> what the merits of going backwards are.

Ok, seems like the sort of cleanups I proposed would not clash with current git policies. I'll readily agree that the timing of their adoption might not really fit with a rc4, but posting them for the queue does not seem outrageous.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum