Re: Shell script cleanups/style changes?

From: Robert Schiele <rschiele@gmail.com>
Date: Aug 2, 2007, 21:41 UTC
Message-ID: <20070802214103.GT29424@schiele.dyndns.org>
In-Reply-To: <7vsl71tyyq.fsf@assigned-by-dhcp.cox.net>

On Thu, Aug 02, 2007 at 10:57:31PM +0200, David Kastrup wrote:

> Most of the "new tricks" I try on bash, dash and ash.

Well, those are not really the most challenging one. Thus you should either test on more or just believe those people that have other shells that it does not work.

> I am confused now: a different poster adamantly stated that /bin/sh on
> Solaris did not support those constructs, and that every functionality
> of git was working fine for him.

No, you should read the mails you are refering to. I said that the most important stuff does work. Apparently this did not yet hurt me on the platform. Thus we have to decide whether we want some textbook example code and thus break this platform completely or whether we want to fix the issues you have listed and thus have a more portable application.

> Sure.  What about the git-rebase line using $(($end - $msgnum)) ?

Bad on Solaris:

$ uname -a SunOS solaris10-x64 5.10 Generic i86pc i386 i86pc $ end=1 $ msgnum=5 $ echo $(($end - $msgnum)) syntax error: `(' unexpected $

> Too bad: this should mean that $EDITOR can get called from C...  I've
> been glad to see that so far this could be avoided.

Why is it bad to call the editor from C?

On Thu, Aug 02, 2007 at 02:21:01PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> David Kastrup <dak@gnu.org> writes:
> 
> > Sure.  What about the git-rebase line using $(($end - $msgnum)) ?
> > That's even more risque than ##.
> 
> Is it really risque?  I do not think we have heard trouble with
> the arith expansion from anybody.  A few mistakes in the past

See above.

> I do not think we have trouble with ${parameter#word}.  Much

$ uname -a SunOS solaris10-x64 5.10 Generic i86pc i386 i86pc $ parameter=bla $ echo ${parameter#word} bad substitution $

> less with ${parameter+word}; it has been in /bin/sh forever.

That one is ok for Solaris.

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."