Re: Shell script cleanups/style changes?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 2, 2007, 23:05 UTC
- Message-ID
- <7vwswdsfjp.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <85vebxy47e.fsf@lola.goethe.zz>
David Kastrup <dak@gnu.org> writes:
Show 12 quoted lines
> Robert Schiele <rschiele@gmail.com> writes: > ... >> Thus we have to decide whether we want some textbook example code >> and thus break this platform completely or whether we want to fix >> the issues you have listed and thus have a more portable >> application. > > The "issues" are with Solaris, apparently. There is always a price > for portability. If Solaris users can fix their problems with a > global search and replace of the first line in *.sh, the question is > whether it is worth the hassle of having unreadable but "portable" > code. After all, it has to be read also by humans.
I am in the camp of avoiding "it is even in POSIX so it's your fault if your shell does not support it". We do not take POSIX too seriously in that way, although we do say "let's not use it, it is not even in POSIX". In other words, I've been trying to be, and as a result of that we are, fairly conservative.
However, there is a line we need to draw when bending bacwards for compatibility, and I think a system that does not have a working command substitution $( ... ) is on the other side of that line.