Re: Shell script cleanups/style changes?

From: David Kastrup <dak@gnu.org>
Date: Aug 2, 2007, 21:02 UTC
Message-ID: <85ir7xzm46.fsf@lola.goethe.zz>
In-Reply-To: <fcaeb9bf0708021356v57b29a70yb69a2fa000bd5b55@mail.gmail.com>

"Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:

Show 7 quoted lines

> On 8/2/07, Junio C Hamano <gitster@pobox.com> wrote:
>> Non POSIX substitions such as ${parameter/pattern/string} and
>> ${parameter:offset} are not to be used.  We do not want to
>> depend on bash.
>
> There is in a test (t5300-pack-objects.sh) but I guess the
> restrictions do not apply on tests.

Oh, but they definitely should. Precisely on those platforms with shells not generally in use by the developers it becomes _most_ important to reliably be able to trace failed tests to problems with the _commands_, not problems with the tests.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum