Re: Shell script cleanups/style changes?

From: Robert Schiele <rschiele@gmail.com>
Date: Aug 4, 2007, 20:32 UTC
Message-ID: <20070804203220.GZ29424@schiele.dyndns.org>
In-Reply-To: <873ayzojw7.fsf@mid.deneb.enyo.de>

On Sat, Aug 04, 2007 at 09:10:00AM +0200, Florian Weimer wrote:

Show 18 quoted lines

> * Robert Schiele:
> 
> >> Sure.  What about the git-rebase line using $(($end - $msgnum)) ?
> >
> > Bad on Solaris:
> >
> > $ uname -a
> > SunOS solaris10-x64 5.10 Generic i86pc i386 i86pc
> > $ end=1
> > $ msgnum=5
> > $ echo $(($end - $msgnum))
> > syntax error: `(' unexpected
> > $ 
> 
> Is this with /usr/xpg4/bin/sh or /bin/sh?  The latter is not POSIX and
> should not be used by GIT, IMHO, otherwise there will be endless
> issues in less-well-tested code paths.  Is rewriting the shebang lines
> to use the POSIX shell an option for GIT?

Hi Florian,

I recommend you read the other mails in this thread. This issue is already completely resolved.

Robert

-- 
Robert Schiele
Dipl.-Wirtsch.informatiker	mailto:rschiele@gmail.com

"Quidquid latine dictum sit, altum sonatur."