Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs instead of custom buffers.

From: David Kastrup <dak@gnu.org>
Date: Sep 8, 2007, 11:59 UTC
Message-ID: <851wd9xt98.fsf@lola.goethe.zz>
In-Reply-To: <11892523992038-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

>   Also remove the "len" parameter, as:
>   (1) it was used as a max boundary, and every caller used ~0u
>   (2) we check for final NUL no matter what, so it doesn't help for speed.

That sounds like a change that makes improvement of callers impossible when it is found out that it leads to a performance issue. Is it only the pretty-print that is affected?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.