From: David Kastrup Date: Sat, 08 Sep 2007 11:59:31 GMT Subject: Re: [PATCH 3/3] Rework pretty_print_commit to use strbufs instead of custom buffers. Message-ID: <851wd9xt98.fsf@lola.goethe.zz> In-Reply-To: <11892523992038-git-send-email-madcoder@debian.org> Pierre Habouzit writes: > Also remove the "len" parameter, as: > (1) it was used as a max boundary, and every caller used ~0u > (2) we check for final NUL no matter what, so it doesn't help for speed. That sounds like a change that makes improvement of callers impossible when it is found out that it leads to a performance issue. Is it only the pretty-print that is affected? -- David Kastrup, Kriemhildstr. 15, 44793 Bochum