Re: [PATCH 1/7] Rework strbuf API and semantics.
- From
Jeff King <peff@peff.net>
- Date
- Sep 6, 2007, 14:21 UTC
- Message-ID
- <20070906142155.GB3002@coredump.intra.peff.net>
- In-Reply-To
- <Pine.LNX.4.64.0709061506330.28586@racer.site>
On Thu, Sep 06, 2007 at 03:09:28PM +0100, Johannes Schindelin wrote:
> let me thank you for this very nicely done patch series. Except for 5/7, > they look pretty much obvious changes to me. I'll review that in detail > later.
I second that; I am glad somebody is taking an interest in this area (though I haven't closely reviewed the patches yet).
Show 5 quoted lines
> > +#define STRBUF_INIT { 0, 0, 0, NULL }
>
> Would not "struct strbuf sb = { 0 };" have the same effect? (I am not so
> standards-keen as other people, who I have no doubt will gladly answer
> this one.)Yes, it would, according to the standard.
-Peff