git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add GIT_FAST_STAT mode for Cygwin

From
Alex Riesen <raa.lkml@gmail.com>
Date
Sep 24, 2008, 11:25 UTC
Message-ID
<81b0412b0809240425t63a2a28cw1cc0c0d95b3290f7@mail.gmail.com>
In-Reply-To
<20080923165247.GO21650@dpotapov.dyndns.org>
2008/9/23 Dmitry Potapov <dpotapov@gmail.com>:
Show 14 quoted lines
> On Tue, Sep 23, 2008 at 04:37:14PM +0200, Alex Riesen wrote:
>> 2008/9/23 Dmitry Potapov <dpotapov@gmail.com>:
>> >
>> > This fast mode works only for relative paths. It is assumed that the
>> > whole repository is located inside one directory without using Cygwin
>> > mount to bind external paths inside of the current tree.
>>
>> Why runtime conditional? Why conditional at all?
>
> I thought that in rather unusual circumstances (such as using Cygwin
> mount to connect separately directories in one tree), this fast version
> may not work. So, I made it conditional. It is runtime conditional,
> because most users do not build Git themselves but install a ready
> Cygwin package.

So? How about make the fast version _always_ work? We don't seem to fallback to copy+unlink everytime the POSIX rename fails.

Besides it will remove your setup code, which looks bigger and provoked more discussion than the real subject itself.

Previous: Jakub NarebskiNext: Dmitry Potapov
Message 5 of 25 in “add GIT_FAST_STAT mode for Cygwin”
  1. add GIT_FAST_STAT mode for CygwinDmitry Potapov, Sep 23, 2008
  2. Alex RiesenSep 23, 2008
  3. Dmitry PotapovSep 23, 2008
  4. Jakub NarebskiSep 23, 2008
  5. Alex RiesenSep 24, 2008
  6. Dmitry PotapovSep 24, 2008
  7. Alex RiesenSep 24, 2008
  8. Shawn O. PearceSep 24, 2008
  9. Alex RiesenSep 24, 2008
  10. Shawn O. PearceSep 24, 2008
  11. Alex RiesenSep 24, 2008
  12. Shawn O. PearceSep 23, 2008
  13. Dmitry PotapovSep 23, 2008
  14. Shawn O. PearceSep 23, 2008
  15. Dmitry PotapovSep 23, 2008
  16. Shawn O. PearceSep 23, 2008
  17. Dmitry PotapovSep 23, 2008
  18. Shawn O. PearceSep 23, 2008
  19. Johannes SixtSep 23, 2008
  20. Dmitry PotapovSep 23, 2008
  21. Johannes SixtSep 23, 2008
  22. Dmitry PotapovSep 23, 2008
  23. Add a "fast stat" mode for CygwinMarcus Griep, Sep 27, 2008
  24. Alex RiesenSep 27, 2008
  25. Dmitry PotapovSep 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.