git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add GIT_FAST_STAT mode for Cygwin

From
Dmitry Potapov <dpotapov@gmail.com>
Date
Sep 24, 2008, 14:03 UTC
Message-ID
<20080924140358.GX21650@dpotapov.dyndns.org>
In-Reply-To
<81b0412b0809240425t63a2a28cw1cc0c0d95b3290f7@mail.gmail.com>
On Wed, Sep 24, 2008 at 01:25:06PM +0200, Alex Riesen wrote:
Show 10 quoted lines
> 2008/9/23 Dmitry Potapov <dpotapov@gmail.com>:
> >
> > I thought that in rather unusual circumstances (such as using Cygwin
> > mount to connect separately directories in one tree), this fast version
> > may not work. So, I made it conditional. It is runtime conditional,
> > because most users do not build Git themselves but install a ready
> > Cygwin package.
> 
> So? How about make the fast version _always_ work? We don't seem
> to fallback to copy+unlink everytime the POSIX rename fails.

I am not sure that I understand your analogue here. First, rename has never meant to work as copy+unlink. Second, I don't fall back on some other code when the implementation provided by Cygwin fails. I replace the Cygwin implementation with a faster but a bit hackish version. Yes, it works fine in almost all practical cases I aware of, but I cannot guarantee identical behavior in _all_ cases.

Frankly, I don't have strong preference here neither for making this fast version always work nor leave it conditional (perhaps, with the default setting use-fast-version). So, whatever the majority decides is fine with me.

> Besides it will remove your setup code, which looks bigger and provoked
> more discussion than the real subject itself.

I believe Shawn wanted it to be configurable on per-repository basis. I have just finished re-writing the code in the way he suggested, so I hope all objections with the setup code are resolved now. I will send the new version a bit later, I did not have time to test it yet.

Dmitry
Previous: Alex RiesenNext: Alex Riesen
Message 6 of 25 in “add GIT_FAST_STAT mode for Cygwin”
  1. add GIT_FAST_STAT mode for CygwinDmitry Potapov, Sep 23, 2008
  2. Alex RiesenSep 23, 2008
  3. Dmitry PotapovSep 23, 2008
  4. Jakub NarebskiSep 23, 2008
  5. Alex RiesenSep 24, 2008
  6. Dmitry PotapovSep 24, 2008
  7. Alex RiesenSep 24, 2008
  8. Shawn O. PearceSep 24, 2008
  9. Alex RiesenSep 24, 2008
  10. Shawn O. PearceSep 24, 2008
  11. Alex RiesenSep 24, 2008
  12. Shawn O. PearceSep 23, 2008
  13. Dmitry PotapovSep 23, 2008
  14. Shawn O. PearceSep 23, 2008
  15. Dmitry PotapovSep 23, 2008
  16. Shawn O. PearceSep 23, 2008
  17. Dmitry PotapovSep 23, 2008
  18. Shawn O. PearceSep 23, 2008
  19. Johannes SixtSep 23, 2008
  20. Dmitry PotapovSep 23, 2008
  21. Johannes SixtSep 23, 2008
  22. Dmitry PotapovSep 23, 2008
  23. Add a "fast stat" mode for CygwinMarcus Griep, Sep 27, 2008
  24. Alex RiesenSep 27, 2008
  25. Dmitry PotapovSep 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.