git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Add a "fast stat" mode for Cygwin

From
Dmitry Potapov <dpotapov@gmail.com>
Date
Sep 27, 2008, 10:39 UTC
Message-ID
<20080927103911.GD21650@dpotapov.dyndns.org>
In-Reply-To
<1222498926-30635-1-git-send-email-marcus@griep.us>
Hi Marcus,
On Sat, Sep 27, 2008 at 03:02:06AM -0400, Marcus Griep wrote:
Show 5 quoted lines
> 
>  This is a substitute patch that takes care of many of the concerns already
>  posted to this thread regarding the patch.  Sorry if it steps on your toes,
>  Dmitry.  You began scratching my itch, so I wanted to jump in and scratch
>  some more.

I am sorry I was not able to send my patches earlier. I had them ready by the end of the day when we had the discussion, but I have not had an opportunity to test it on Windows till today.

I have only skimmed over your patch, but there are a few changes that I really dislike about your patch. You changed the semantic of _choice functions. While I use it as stubs to choose what implementation to use, you make them part of implementation, which is always called. So I do not understand why you left the comment saying that they are only stubs and then why you need function pointers at all then.

Also, you made some changes to MinGW (I don't know if you tested it), but any change like removing _getdrive() from MinGW version is better to move into separately patch (or, at least, clearly state them in the commit comment).

Anyway, thanks for your efforts, but if you want to go ahead with some other match of mine (especially Windows related), please, let me know, so we can avoid stepping on each other toes.

Dmitry
Previous: Alex Riesen
Message 25 of 25 in “add GIT_FAST_STAT mode for Cygwin”
  1. add GIT_FAST_STAT mode for CygwinDmitry Potapov, Sep 23, 2008
  2. Alex RiesenSep 23, 2008
  3. Dmitry PotapovSep 23, 2008
  4. Jakub NarebskiSep 23, 2008
  5. Alex RiesenSep 24, 2008
  6. Dmitry PotapovSep 24, 2008
  7. Alex RiesenSep 24, 2008
  8. Shawn O. PearceSep 24, 2008
  9. Alex RiesenSep 24, 2008
  10. Shawn O. PearceSep 24, 2008
  11. Alex RiesenSep 24, 2008
  12. Shawn O. PearceSep 23, 2008
  13. Dmitry PotapovSep 23, 2008
  14. Shawn O. PearceSep 23, 2008
  15. Dmitry PotapovSep 23, 2008
  16. Shawn O. PearceSep 23, 2008
  17. Dmitry PotapovSep 23, 2008
  18. Shawn O. PearceSep 23, 2008
  19. Johannes SixtSep 23, 2008
  20. Dmitry PotapovSep 23, 2008
  21. Johannes SixtSep 23, 2008
  22. Dmitry PotapovSep 23, 2008
  23. Add a "fast stat" mode for CygwinMarcus Griep, Sep 27, 2008
  24. Alex RiesenSep 27, 2008
  25. Dmitry PotapovSep 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.