From: Alex Riesen Date: Wed, 24 Sep 2008 11:25:06 GMT Subject: Re: [PATCH] add GIT_FAST_STAT mode for Cygwin Message-ID: <81b0412b0809240425t63a2a28cw1cc0c0d95b3290f7@mail.gmail.com> In-Reply-To: <20080923165247.GO21650@dpotapov.dyndns.org> 2008/9/23 Dmitry Potapov : > On Tue, Sep 23, 2008 at 04:37:14PM +0200, Alex Riesen wrote: >> 2008/9/23 Dmitry Potapov : >> > >> > This fast mode works only for relative paths. It is assumed that the >> > whole repository is located inside one directory without using Cygwin >> > mount to bind external paths inside of the current tree. >> >> Why runtime conditional? Why conditional at all? > > I thought that in rather unusual circumstances (such as using Cygwin > mount to connect separately directories in one tree), this fast version > may not work. So, I made it conditional. It is runtime conditional, > because most users do not build Git themselves but install a ready > Cygwin package. So? How about make the fast version _always_ work? We don't seem to fallback to copy+unlink everytime the POSIX rename fails. Besides it will remove your setup code, which looks bigger and provoked more discussion than the real subject itself.