git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

From
Junio C Hamano <gitster@pobox.com>
Date
May 16, 2013, 16:49 UTC
Message-ID
<7vzjvu6faq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAMP44s17aD_ryeGWQazTcJ3nrhe6C9TLhKHhrUnys=Yj_ATa0A@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 10 quoted lines
> On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> I find it extremely annoying that an obviously correct patch is not
>>> merged...
>>
>> A patch that receives "this breaks style" comments
>
> *Invalid* "this breaks style" comments, because it doesn't break any
> style mentioned in Documentation/CodingGuidelines.
    As for more concrete guidelines, just imitate the existing code
    (this is a good guideline, no matter which project you are
    contributing to). It is always preferable to match the _local_
    convention

The document does not spell out all the details, but that does not mean you can ignore what others say and many find a sensible style request.

Previous: Felipe ContrerasNext: Felipe Contreras
Message 20 of 40 in “trivial patches”
  1. 0/4 trivial patchesFelipe Contreras, May 9, 2013
  2. 1/4 documentation: trivial style cleanupsFelipe Contreras, May 9, 2013
  3. Junio C HamanoMay 9, 2013
  4. 2/4 transport-helper: trivial style cleanupFelipe Contreras, May 9, 2013
  5. Junio C HamanoMay 9, 2013
  6. 3/4 {fast-export,transport-helper}: style cleanupsFelipe Contreras, May 9, 2013
  7. John SzakmeisterMay 9, 2013
  8. Felipe ContrerasMay 9, 2013
  9. John SzakmeisterMay 9, 2013
  10. Felipe ContrerasMay 9, 2013
  11. Ramkumar RamachandraMay 9, 2013
  12. Felipe ContrerasMay 9, 2013
  13. Junio C HamanoMay 9, 2013
  14. Felipe ContrerasMay 9, 2013
  15. Junio C HamanoMay 9, 2013
  16. Felipe ContrerasMay 9, 2013
  17. Felipe ContrerasMay 16, 2013
  18. Junio C HamanoMay 16, 2013
  19. Felipe ContrerasMay 16, 2013
  20. Junio C HamanoMay 16, 2013
  21. Felipe ContrerasMay 16, 2013
  22. Junio C HamanoMay 16, 2013
  23. Ramkumar RamachandraMay 16, 2013
  24. Felipe ContrerasMay 16, 2013
  25. Felipe ContrerasMay 16, 2013
  26. Felipe ContrerasMay 17, 2013
  27. Ramkumar RamachandraMay 17, 2013
  28. Felipe ContrerasMay 17, 2013
  29. Junio C HamanoMay 17, 2013
  30. Felipe ContrerasMay 17, 2013
  31. Matthieu MoyMay 17, 2013
  32. Felipe ContrerasMay 17, 2013
  33. Matthieu MoyMay 17, 2013
  34. Felipe ContrerasMay 17, 2013
  35. 4/4 fast-export: trivial cleanupFelipe Contreras, May 9, 2013
  36. John SzakmeisterMay 9, 2013
  37. Felipe ContrerasMay 9, 2013
  38. John SzakmeisterMay 9, 2013
  39. Junio C HamanoMay 9, 2013
  40. Felipe ContrerasMay 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.