Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 16, 2013, 18:34 UTC
Message-ID: <CALkWK0=LuycRpuwBMjfiSk9qy2Y6VZsmmhNLpKdovKX4rZ=hTA@mail.gmail.com>
In-Reply-To: <7vfvxm6biv.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

>     (defun linux-style ()
>       "C mode with adjusted defaults for use with the Linux kernel."
>       (interactive)
>       (c-set-style "K&R")

There's actually a "linux" style you can inherit from.

May I suggest looking at Documentation/CodingStyle in linux.git for this:

(defun c-lineup-arglist-tabs-only (ignored)
  "Line up argument lists by tabs, not spaces"
  (let* ((anchor (c-langelem-pos c-syntactic-element))
	 (column (c-langelem-2nd-pos c-syntactic-element))
	 (offset (- (1+ column) anchor))
	 (steps (floor offset c-basic-offset)))
    (* (max steps 1)
       c-basic-offset)))

(add-hook 'c-mode-common-hook
          (lambda ()
            ;; Add kernel style
            (c-add-style
             "linux-tabs-only"
             '("linux" (c-offsets-alist
                        (arglist-cont-nonempty
                         c-lineup-gcc-asm-reg
                         c-lineup-arglist-tabs-only))))))

(add-hook 'c-mode-hook
          (lambda ()
            (let ((filename (buffer-file-name)))
              ;; Enable kernel mode for the appropriate files
              (when (and filename
                         (string-match (expand-file-name "~/src/linux-trees")
                                       filename))
                (setq indent-tabs-mode t)
                (c-set-style "linux-tabs-only")))))

I use this for everything.