From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 16 May 2013 16:49:17 GMT
Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
Message-ID: <7vzjvu6faq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s17aD_ryeGWQazTcJ3nrhe6C9TLhKHhrUnys=Yj_ATa0A@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> I find it extremely annoying that an obviously correct patch is not
>>> merged...
>>
>> A patch that receives "this breaks style" comments
>
> *Invalid* "this breaks style" comments, because it doesn't break any
> style mentioned in Documentation/CodingGuidelines.

    As for more concrete guidelines, just imitate the existing code
    (this is a good guideline, no matter which project you are
    contributing to). It is always preferable to match the _local_
    convention

The document does not spell out all the details, but that does not
mean you can ignore what others say and many find a sensible style
request.