git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 17, 2013, 17:18 UTC
Message-ID
<CAMP44s1uDEUxxJWwHi=J1Jf=CnApi99BW3ZxTPUa7T+py==gfQ@mail.gmail.com>
In-Reply-To
<vpqwqqxbka7.fsf@grenoble-inp.fr>

On Fri, May 17, 2013 at 12:14 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 14 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> THERE IS NO STYLE BREAKAGE.
>>>
>>> Repeating something, and even making it all caps does not make it true.
>>
>> Tell that to Junio. He is also repeating the same.
>
> Junio explained you carefully how the former code was purposely aligning
> stuff and you broke it.

Yeah, and it was purposely adding a space between the parenthesis, that doesn't mean it's the desired style.

The fact that something is a certain way, or was, doesn't imply it *should* be that way. Explaining what the code was formerly doing is no argument, it's merely an observation.

>> I actually provided *evidence*. Did you miss it?
>
> Star-emphasis does not make things true either. Again, you're losing
> your time, and won't lose mine any further.
Of course, because you have no evidence or arguments.
-- 
Felipe Contreras
Previous: Matthieu MoyNext: Felipe Contreras
Message 34 of 40 in “trivial patches”
  1. 0/4 trivial patchesFelipe Contreras, May 9, 2013
  2. 1/4 documentation: trivial style cleanupsFelipe Contreras, May 9, 2013
  3. Junio C HamanoMay 9, 2013
  4. 2/4 transport-helper: trivial style cleanupFelipe Contreras, May 9, 2013
  5. Junio C HamanoMay 9, 2013
  6. 3/4 {fast-export,transport-helper}: style cleanupsFelipe Contreras, May 9, 2013
  7. John SzakmeisterMay 9, 2013
  8. Felipe ContrerasMay 9, 2013
  9. John SzakmeisterMay 9, 2013
  10. Felipe ContrerasMay 9, 2013
  11. Ramkumar RamachandraMay 9, 2013
  12. Felipe ContrerasMay 9, 2013
  13. Junio C HamanoMay 9, 2013
  14. Felipe ContrerasMay 9, 2013
  15. Junio C HamanoMay 9, 2013
  16. Felipe ContrerasMay 9, 2013
  17. Felipe ContrerasMay 16, 2013
  18. Junio C HamanoMay 16, 2013
  19. Felipe ContrerasMay 16, 2013
  20. Junio C HamanoMay 16, 2013
  21. Felipe ContrerasMay 16, 2013
  22. Junio C HamanoMay 16, 2013
  23. Ramkumar RamachandraMay 16, 2013
  24. Felipe ContrerasMay 16, 2013
  25. Felipe ContrerasMay 16, 2013
  26. Felipe ContrerasMay 17, 2013
  27. Ramkumar RamachandraMay 17, 2013
  28. Felipe ContrerasMay 17, 2013
  29. Junio C HamanoMay 17, 2013
  30. Felipe ContrerasMay 17, 2013
  31. Matthieu MoyMay 17, 2013
  32. Felipe ContrerasMay 17, 2013
  33. Matthieu MoyMay 17, 2013
  34. Felipe ContrerasMay 17, 2013
  35. 4/4 fast-export: trivial cleanupFelipe Contreras, May 9, 2013
  36. John SzakmeisterMay 9, 2013
  37. Felipe ContrerasMay 9, 2013
  38. John SzakmeisterMay 9, 2013
  39. Junio C HamanoMay 9, 2013
  40. Felipe ContrerasMay 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.