Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

From: John Szakmeister <john@szakmeister.net>
Date: May 9, 2013, 08:46 UTC
Message-ID: <CAEBDL5XZhEo14WKiz2m3KFRX+NsTFhmcz3adSti33RATMd897w@mail.gmail.com>
In-Reply-To: <1368062218-22440-4-git-send-email-felipe.contreras@gmail.com>

On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 10 quoted lines

> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  builtin/fast-export.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index d60d675..8091354 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -135,7 +135,7 @@ static void export_blob(const unsigned char *sha1)

[snip]

Show 7 quoted lines

> @@ -289,13 +289,13 @@ static void handle_commit(struct commit *commit, struct rev_info *rev)
>         parse_commit(commit);
>         author = strstr(commit->buffer, "\nauthor ");
>         if (!author)
> -               die ("Could not find author in commit %s",
> +               die("Could not find author in commit %s",
>                      sha1_to_hex(commit->object.sha1));

It looks like your simple replace didn't account for calls with multiple lines. Now the remaining lines don't line up. :-) There's several more places like this in the patch.

-John