Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying

From: Junio C Hamano <junkio@cox.net>
Date: Nov 24, 2006, 02:54 UTC
Message-ID: <7vvel5ftav.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061124014205.GA19515@sigio.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> On Fri, Nov 24, 2006 at 12:52:13PM +1300, Martin Langhoff wrote:
>
>> You are right. It should be something along the lines of
>> 
>>  # discard headers until first blank line
>>  while (<$s> ne '') {
>>      # nothing
>>  }
>> 
>> that is, assuming we can just ignore headers happily.
>
> That code won't work; the value of a blank line will actually be "\n"
> (or "\r\n").

Good point. For an HTTP proxy the kosher line termination would indeed be "\r\n".