Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying

From: Jeff King <peff@peff.net>
Date: Nov 24, 2006, 14:57 UTC
Message-ID: <20061124145700.GA13947@coredump.intra.peff.net>
In-Reply-To: <7vfyc9cjci.fsf@assigned-by-dhcp.cox.net>

On Fri, Nov 24, 2006 at 12:57:49AM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> +			# Skip up to the empty line of the proxy server output
> +			# including the response headers.
> +			while ($rep = <$s>) {
> +				last if (!defined $rep ||
> +					 $rep eq "\n" ||
> +					 $rep eq "\r\n");
> +			}

Nit: checking defined($rep) inside the loop is redundant.