Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying

From: Jeff King <peff@peff.net>
Date: Nov 24, 2006, 01:42 UTC
Message-ID: <20061124014205.GA19515@sigio.intra.peff.net>
In-Reply-To: <46a038f90611231552x3e33eec4w7863ce6a1da5781b@mail.gmail.com>

On Fri, Nov 24, 2006 at 12:52:13PM +1300, Martin Langhoff wrote:

Show 8 quoted lines

> You are right. It should be something along the lines of
> 
>  # discard headers until first blank line
>  while (<$s> ne '') {
>      # nothing
>  }
> 
> that is, assuming we can just ignore headers happily.

That code won't work; the value of a blank line will actually be "\n" (or "\r\n"). So you probably want:

while (<$s>) {
  chomp; chomp;
  last unless $_;
}

or perhaps more readably:

while (<$s>) {
  last if $_ eq "\n" || $_ eq "\r\n";
}