Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying

From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Nov 23, 2006, 23:52 UTC
Message-ID: <46a038f90611231552x3e33eec4w7863ce6a1da5781b@mail.gmail.com>
In-Reply-To: <7vlkm1ix7b.fsf@assigned-by-dhcp.cox.net>

On 11/24/06, Junio C Hamano <junkio@cox.net> wrote:

Show 6 quoted lines

> It is more about HTTP proxying and it is my understanding that
> response to CONNECT method request has that empty line after the
> successful (2xx) response line and zero or more response
> headers.  The code is still wrong; it does not have a loop to
> discard the potential response headers that come before the
> empty line the code we are discussing discards.

You are right. It should be something along the lines of

  # discard headers until first blank line
  while (<$s> ne '') {
      # nothing
  }

that is, assuming we can just ignore headers happily.

cheers,