Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying

From: Ignacio Arenaza <iarenuno@eteo.mondragon.edu>
Date: Nov 27, 2006, 16:27 UTC
Message-ID: <67bqmsn9d6.fsf@poseidon.eteo.mondragon.edu>
In-Reply-To: <7vhcwpawvg.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

> I deliberately left out the style changes to avoid cluttering
> the patch; as I said in my first response, that should come as a
> separate patch that does not change anything else.

Ok, I've had a look at git-cvsimport.perl and I can't come up with a consistent style for the 'if () {' sentence. According to grep there are 50 instances of 'if(...)' and 39 instances of 'if (...)', so I don't know which is the preferred one. And I can't find a CodingStyle document either.

Which way should I fix them? And should I fix the whole file, or just the ones in my original patch?

Saludos. Iñaki.

-- 
School of Management
Mondragon University
20560 Oñati - Spain
+34 943 718009 (ext. 225)