Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 04:57 UTC
Message-ID: <7vve5zy72p.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <9b3e2dc20801111825i644da598i7556ef700b870445@mail.gmail.com>

"Stephen Sinclair" <radarsat1@gmail.com> writes:

Show 14 quoted lines

>> In a properly configured repository, telling you who git thinks
>> you are is _ALWAYS_ useless (that's the definition of "properly
>> configured").  Just admit it.
>
> Well, I'll admit that I don't really understand you here.
> Maybe I'm still too much of a git newbie on this.  (Fair enough.)
> Right now the only way to make sure I'm committing as myself with my
> proper email address is to:
>
> --  remember to "git-config --list", and check that my email is listed.
> --  "git-commit; git-log", and remember to check the last entry before
> doing a "git-push".
>
> Am I missing something?

They are both valid means to make sure you did not misconfigure.

You omitted the part that matters from the part you quoted above, but this discussion was about "showing AUTHOR if it is different from me", which was _one of_ the two conditions I suggested in my counterproposal, and I was saying that it is useless to expect that you would be able to find a misconfiguration when AUTHOR is shown for this first reason. This part is _not_ about catching your misconfiguration.

The other part is about the misconfiguration catching.

> Especially considering the default name is taken from the hostname
> anyway -- you're taking the local hostname and then checking with a
> rule to see if it might be localhost.

Yes, and earlier you said one of the undesirable ones was "yourname@foo.local" (and others were "yourname@foo.(none)"). IOW, "localhost" is one of the things you want to catch as unconfigured bogosity that you want to catch, isn't it?

And that is _the other_ condition in my counterproposal to show AUTHOR.

To rephrase, you would show AUTHOR when one of the conditions holds true, either:

 (1) "not me" (so that we can remind that other's commit is
     being amended); _OR_

 (2) "funny me" (so that we can catch misconfiguration.

The latter would not have to trigger once you configure your ~/.gitconfig (or .git/config) properly.