git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

From
Jeff King <peff@peff.net>
Date
Jan 12, 2008, 04:52 UTC
Message-ID
<20080112045231.GB5211@coredump.intra.peff.net>
In-Reply-To
<7vejcnzu5z.fsf@gitster.siamese.dyndns.org>
On Fri, Jan 11, 2008 at 05:53:12PM -0800, Junio C Hamano wrote:
Show 6 quoted lines
> The official party line to defend the existing behaviour is that
> there is no need to configure anything, when the host and gecos
> is done properly.  But I tend to agree with you that quite a lot
> of systems are not "done properly", and users cannot do much
> about it in some cases.  I think most of misconfigured systems
> are personal boxes they have control over but not all.

I think there are plenty of reasons for the host/gecos information not being useful. Is a workstation whose hostname is not a valid mailing address really not "done properly"?

> Perhaps we could disable the code that reads from hostname and
> gecos, and instead always force the users to configure.  But
> that kind of change is not something I'd want to be discussing
> right now.

This is obviously not 1.5.4 material, so I haven't given it that much thought either. But perhaps Stephen's "author message" should simply trigger any time the author is pulled from gecos? I suppose that would annoy people who use this feature all the time, but they can silence the "warning" with a simple git-config.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 17 in “Add committer and author names to top of COMMIT_EDITMSG.”
  1. Add committer and author names to top of COMMIT_EDITMSG.Stephen Sinclair, Jan 11, 2008
  2. Johannes SchindelinJan 11, 2008
  3. Junio C HamanoJan 11, 2008
  4. Stephen SinclairJan 12, 2008
  5. Junio C HamanoJan 12, 2008
  6. Stephen SinclairJan 12, 2008
  7. Junio C HamanoJan 12, 2008
  8. Stephen SinclairJan 12, 2008
  9. Junio C HamanoJan 12, 2008
  10. Stephen SinclairJan 12, 2008
  11. Junio C HamanoJan 12, 2008
  12. Jeff KingJan 12, 2008
  13. Junio C HamanoJan 12, 2008
  14. Junio C HamanoJan 12, 2008
  15. Jeff KingJan 12, 2008
  16. Junio C HamanoJan 12, 2008
  17. Jeff KingJan 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.