Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 05:30 UTC
Message-ID: <7vlk6vy5jj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vprw7y6mz.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> This is obviously not 1.5.4 material, so I haven't given it that much
>> thought either. But perhaps Stephen's "author message" should simply
>> trigger any time the author is pulled from gecos?

I think what we could do if we wanted to protect people from unconfigured identity is to stop pulling names from gecos and hostname, and respect _only_ environment and config.

And fail any operation that we would want configured name and email (names in reflog does not count as such an operation --- we've made that mistake once, which made "git clone" impossible before setting up $HOME/.gitconfig).

That I think I can live with.

If we do that, we do not have to see two extra lines (COMMITTER and AUTHOR) that spells our own name in the commit message buffer, which almost always will be a total waste of space.