Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 00:22 UTC
Message-ID: <7vbq7r28qo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <9b3e2dc20801111609t3103af1frc23519cab43ae8be@mail.gmail.com>

"Stephen Sinclair" <radarsat1@gmail.com> writes:

Show 8 quoted lines

>> I'd almost agree with this patch if if added AUTHOR but not
>> COMMITTER, and only when AUTHOR is different from me.  That
>> would help reassure anybody while amending other's changes.
>> COMMITTER is always me and I should not reminded with extra
>> lines that waste precious screen real estate.
>
> The purpose of my patch was to remind _myself_ what my name is, in
> case I hadn't configured it correctly.

In that case, I would imagine a rule like this would be more appropriate than unconditionally showing AUTHOR/COMMITTER in all cases:

 * If AUTHOR_NAME+EMAIL is different from AUTHOR_NAME+EMAIL that
   I would normally get for myself, or

 * If AUTHOR_NAME+EMAIL contains garbage identifier commonly
   found when misconfigured (e.g. ".(none)" at the end of
   e-mail),

then show AUTHOR. In addition, if it is the latter case, give hints to configure before casting the mistake in stone.