Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 08:02 UTC
Message-ID: <7vve5zv5cx.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <9b3e2dc20801112326p2b4eaf96tbd036ed746eff4a3@mail.gmail.com>

"Stephen Sinclair" <radarsat1@gmail.com> writes:

Show 11 quoted lines

>> To rephrase, you would show AUTHOR when one of the conditions
>> holds true, either:
>>
>>  (1) "not me" (so that we can remind that other's commit is
>>      being amended); _OR_
>>
>>  (2) "funny me" (so that we can catch misconfiguration.
>
> I definitely agree with (1), though having not really done much
> amending of other people's commits I can't vouch for it.  I think (2)
> might not be very reliable.

Yeah, I tend to agree that (2) is probably impossible to achieve.

Author ident should be reachable e-mail address but some people seem to prefer committer ident to be tied to the actual machine even if that makes the ident something that merely resembles a valid reachable e-mail address but in fact unreachable. For such a committer ident, taking it from hostname would be a reasonable thing to do, but I suspect that is a minority.

Unfortunately we do not have an easy way (other than using GIT_COMMITTER_EMAIL environment) to define different author and committer idents.