git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2010, 05:13 UTC
Message-ID
<7vvd8k3qwm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTikZaPR0iaUkREU83EAyYPbuTvsB2frksHqLSX41@mail.gmail.com>
Nazri Ramliy <ayiehere@gmail.com> writes:
Show 9 quoted lines
> On Tue, Jul 13, 2010 at 9:39 AM, Jay Soffian <jaysoffian@gmail.com> wrote:
>> Don't the scripts that source lib-rebase.sh all source test-lib.sh
>> ahead of it? lib-rebase.sh shouldn't need to re-source test-lib.sh.
>> No?
>
> Ah, sorry for not reporting the exact cause of the problem, it is
> actually due to the fact that test_cmp will be called (later) by
> "fake-editor.sh", which does not source test-lib.sh, and sourcing
> test-lib.sh will not be a correct solution in that case yes?
Ahh, I see.

As we _only_ care about the files being equal (and we do not want any input from that context even when we are running in verbose mode), I think it is probably Ok to use bare "diff" like your patch did. Thanks for an explanation.

People with platforms with a broken "diff" implementations, PLEASE complain LOUDLY if your "diff" is not even capable of comparing two regular files and report if they are the same with its exit status.

Previous: Nazri Ramliy
Message 12 of 12 in “lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR”
  1. 1/2 lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  2. 2/2 rebase -i: Preserve whitespace at beginning of commit header in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  3. Nazri RamliyJul 10, 2010
  4. Junio C HamanoJul 12, 2010
  5. Nazri RamliyJul 13, 2010
  6. Junio C HamanoJul 13, 2010
  7. Nazri RamliyJul 13, 2010
  8. Junio C HamanoJul 12, 2010
  9. Nazri RamliyJul 13, 2010
  10. Jay SoffianJul 13, 2010
  11. Nazri RamliyJul 13, 2010
  12. Junio C HamanoJul 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.