Re: [PATCH 1/2] lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR

From: Nazri Ramliy <ayiehere@gmail.com>
Date: Jul 13, 2010, 01:58 UTC
Message-ID: <AANLkTikZaPR0iaUkREU83EAyYPbuTvsB2frksHqLSX41@mail.gmail.com>
In-Reply-To: <AANLkTik7KDM8Vp_nc1NYRZ89cd1IdyfBffq5vUitbrzj@mail.gmail.com>

On Tue, Jul 13, 2010 at 8:50 AM, Junio C Hamano <gitster@pobox.com> wrote:

> Come on ;-) The most portable, traditional and straightforward way to
> spell that would be "[a-z][a-z]*", no?

On Tue, Jul 13, 2010 at 9:39 AM, Jay Soffian <jaysoffian@gmail.com> wrote:

Show 5 quoted lines

> sed 's/^pick [0-9a-f]\{1,\} //'
>
> is a valid posix BRE. Alternately + can be expressed as:
>
> sed 's/^pick [0-9a-f][0-9a-f]* //'

Thanks for the cluestick guys.

On Tue, Jul 13, 2010 at 8:50 AM, Junio C Hamano <gitster@pobox.com> wrote:

> Somebody is already using test_set_editor inside lib-rebase.sh --- where
> else does it come from other than test-lib?  Don't the scripts that
> include lib-rebase already include test-lib.sh to make test_cmp available
> to you?

On Tue, Jul 13, 2010 at 9:39 AM, Jay Soffian <jaysoffian@gmail.com> wrote:

> Don't the scripts that source lib-rebase.sh all source test-lib.sh
> ahead of it? lib-rebase.sh shouldn't need to re-source test-lib.sh.
> No?

Ah, sorry for not reporting the exact cause of the problem, it is actually due to the fact that test_cmp will be called (later) by "fake-editor.sh", which does not source test-lib.sh, and sourcing test-lib.sh will not be a correct solution in that case yes?

nazri.