git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2010, 06:08 UTC
Message-ID
<7v7hl1fd0n.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1278764821-32647-1-git-send-email-ayiehere@gmail.com>
Nazri Ramliy <ayiehere@gmail.com> writes:
> +test -z "$EXPECT_HEADER" ||
> +	(
> +		grep '^pick' < "$1" | cut -d' ' -f3- > commit_headers.$$ &&

Sending output from grep to cut does not sound very cool; wouldn't a single "sed" invocation more appropriate?

> +		diff "$EXPECT_HEADER" commit_headers.$$ > /dev/null
Is "test_cmp" inappropriate here for some reason?
> +	) ||
Do you need a subshell for this, or just a grouping {} sufficient?
> +	exit
Previous: Nazri RamliyNext: Nazri Ramliy
Message 8 of 12 in “lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR”
  1. 1/2 lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  2. 2/2 rebase -i: Preserve whitespace at beginning of commit header in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  3. Nazri RamliyJul 10, 2010
  4. Junio C HamanoJul 12, 2010
  5. Nazri RamliyJul 13, 2010
  6. Junio C HamanoJul 13, 2010
  7. Nazri RamliyJul 13, 2010
  8. Junio C HamanoJul 12, 2010
  9. Nazri RamliyJul 13, 2010
  10. Jay SoffianJul 13, 2010
  11. Nazri RamliyJul 13, 2010
  12. Junio C HamanoJul 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.