git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] rebase -i: Preserve whitespace at beginning of commit header in $GIT_EDITOR

From
Nazri Ramliy <ayiehere@gmail.com>
Date
Jul 13, 2010, 05:19 UTC
Message-ID
<AANLkTinY9LGB1v8WdwJvFr8f-InaqFx5BozsAH2xlVBQ@mail.gmail.com>
In-Reply-To
<7vzkxw3r8f.fsf@alter.siamese.dyndns.org>
On Tue, Jul 13, 2010 at 1:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> To put it differently, if we really do perceive this "impossible to spot
> if you _only_ look at the insn sheet, but it is easy to remember which
> ones to edit" as an issue, shouldn't the patch at least mention that it
> attempts to solve only one and punts on the other two that are still to be
> fixed later (so that other people can come back to help)?

Thanks for spending your time to clarify the issues. I'll see if I can improve the commit message and/or the patch to handle those issues.

nazri.
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR”
  1. 1/2 lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  2. 2/2 rebase -i: Preserve whitespace at beginning of commit header in $GIT_EDITORNazri Ramliy, Jul 10, 2010
  3. Nazri RamliyJul 10, 2010
  4. Junio C HamanoJul 12, 2010
  5. Nazri RamliyJul 13, 2010
  6. Junio C HamanoJul 13, 2010
  7. Nazri RamliyJul 13, 2010
  8. Junio C HamanoJul 12, 2010
  9. Nazri RamliyJul 13, 2010
  10. Jay SoffianJul 13, 2010
  11. Nazri RamliyJul 13, 2010
  12. Junio C HamanoJul 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.