From: Junio C Hamano Date: Tue, 13 Jul 2010 05:13:45 GMT Subject: Re: [PATCH 1/2] lib-rebase.sh: fake-editor.sh: Allow checking of commit header(s) in $GIT_EDITOR Message-ID: <7vvd8k3qwm.fsf@alter.siamese.dyndns.org> In-Reply-To: Nazri Ramliy writes: > On Tue, Jul 13, 2010 at 9:39 AM, Jay Soffian wrote: >> Don't the scripts that source lib-rebase.sh all source test-lib.sh >> ahead of it? lib-rebase.sh shouldn't need to re-source test-lib.sh. >> No? > > Ah, sorry for not reporting the exact cause of the problem, it is > actually due to the fact that test_cmp will be called (later) by > "fake-editor.sh", which does not source test-lib.sh, and sourcing > test-lib.sh will not be a correct solution in that case yes? Ahh, I see. As we _only_ care about the files being equal (and we do not want any input from that context even when we are running in verbose mode), I think it is probably Ok to use bare "diff" like your patch did. Thanks for an explanation. People with platforms with a broken "diff" implementations, PLEASE complain LOUDLY if your "diff" is not even capable of comparing two regular files and report if they are the same with its exit status.