git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 14, 2009, 02:14 UTC
Message-ID
<7vskmh3gtv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200902130945.20601.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 11 quoted lines
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> Sounds good. I don't use gitweb as DirectoryIndex myself, but
> Acked-by: Jakub Narebski <jnareb@gmail.com>
>
>> +# Another issue with the script being the DirectoryIndex is that the resulting
>> +# $my_url data is not the full script URL: this is good, because we want
>> +# generated links to keep implying the script name if it wasn't explicitly
>> +# indicated in the URL we're handling, but it means that $my_url cannot be used
>> +# as base URL. Therefore, we have to build the base URL ourselves:
>> +our $base_url = $cgi->url(-base => 1) . $ENV{'SCRIPT_NAME'};
Breaks t9500 with 
    [Sat Feb 14 02:12:59 2009] gitweb.perl: Use of uninitialized value in concatenation (.) or string at /pub/git/t/../gitweb/gitweb.perl line 45.

Please be more careful when giving an Ack, and more importantly please do not send a patch that does not even pass the test suite by itself.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 6 of 13 in “gitweb: fix wrong base URL when non-root DirectoryIndex”
  1. gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 12, 2009
  2. Jakub NarebskiFeb 12, 2009
  3. Giuseppe BilottaFeb 13, 2009
  4. gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 13, 2009
  5. Jakub NarebskiFeb 13, 2009
  6. Junio C HamanoFeb 14, 2009
  7. Jakub NarebskiFeb 14, 2009
  8. Giuseppe BilottaFeb 14, 2009
  9. Junio C HamanoFeb 14, 2009
  10. gitweb: fix wrong base URL when non-root DirectoryIndexJakub Narebski, Feb 14, 2009
  11. Giuseppe BilottaFeb 14, 2009
  12. [PATCHv4] gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 15, 2009
  13. Junio C HamanoFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.