Re: [PATCH v3] gitweb: fix wrong base URL when non-root DirectoryIndex

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2009, 19:33 UTC
Message-ID: <7v8wo7lckc.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0902140629pa1ad038pe898aa0d804d0707@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

Show 14 quoted lines

> On Sat, Feb 14, 2009 at 11:04 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> P.S. I wonder why Giuseppe's patch failed to apply, and failed
>> to do fallback 3-way merge...
>
> Because it depends on an additional quoting fix that I sent to the
> mailing list but that apparently didn't get through.
>
>> -               print '<base href="'.esc_url($my_url).'" />\n';
>> +               print '<base href="'.esc_url($base_url).'" />\n';
>
> The quoting fix was here: double quotes are needed because otherwise
> the \n gets in literally. We can probably squash it with this patch.
> Gimme a sec and I'll cook it up again.

Thanks, both.