Re: [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 13, 2009, 07:36 UTC
Message-ID: <cb7bb73a0902122336k1726698ftef85fd4ea0e25085@mail.gmail.com>
In-Reply-To: <200902122303.37499.jnareb@gmail.com>

On Thu, Feb 12, 2009 at 11:03 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 8 quoted lines

> On Thu, 12 Feb 2009, Giuseppe Bilotta wrote:
>
>> From: Giuseppe Bilotta <oblomov@rbot.ratry.ru>
>
> Why different email? Was it intended, or was it an accident, and
> authorship of this patch should be to
>
>        Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

I created this patch on a different computer and forgot to set the authorship as usual. I'll resend.

> Very good. The only thing I wonder about is if we should add this info
> also to gitweb/README, or if it is good as it is now.

I think there is no need to adjust the README, as in fact this fix is needed to make sure that the instructions in README are correct even for subpaths.

> Signoff?

Will add that too.

-- 
Giuseppe "Oblomov" Bilotta