git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gitweb: fix wrong base URL when non-root DirectoryIndex

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Feb 14, 2009, 14:29 UTC
Message-ID
<cb7bb73a0902140629pa1ad038pe898aa0d804d0707@mail.gmail.com>
In-Reply-To
<200902141104.35042.jnareb@gmail.com>
On Sat, Feb 14, 2009 at 11:04 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> P.S. I wonder why Giuseppe's patch failed to apply, and failed
> to do fallback 3-way merge...

Because it depends on an additional quoting fix that I sent to the mailing list but that apparently didn't get through.

> -               print '<base href="'.esc_url($my_url).'" />\n';
> +               print '<base href="'.esc_url($base_url).'" />\n';

The quoting fix was here: double quotes are needed because otherwise the \n gets in literally. We can probably squash it with this patch. Gimme a sec and I'll cook it up again.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Giuseppe Bilotta
Message 11 of 13 in “gitweb: fix wrong base URL when non-root DirectoryIndex”
  1. gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 12, 2009
  2. Jakub NarebskiFeb 12, 2009
  3. Giuseppe BilottaFeb 13, 2009
  4. gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 13, 2009
  5. Jakub NarebskiFeb 13, 2009
  6. Junio C HamanoFeb 14, 2009
  7. Jakub NarebskiFeb 14, 2009
  8. Giuseppe BilottaFeb 14, 2009
  9. Junio C HamanoFeb 14, 2009
  10. gitweb: fix wrong base URL when non-root DirectoryIndexJakub Narebski, Feb 14, 2009
  11. Giuseppe BilottaFeb 14, 2009
  12. [PATCHv4] gitweb: fix wrong base URL when non-root DirectoryIndexGiuseppe Bilotta, Feb 15, 2009
  13. Junio C HamanoFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.