From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 14 Feb 2009 02:14:36 GMT
Subject: Re: [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex
Message-ID: <7vskmh3gtv.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200902130945.20601.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> Sounds good. I don't use gitweb as DirectoryIndex myself, but
> Acked-by: Jakub Narebski <jnareb@gmail.com>
>
>> +# Another issue with the script being the DirectoryIndex is that the resulting
>> +# $my_url data is not the full script URL: this is good, because we want
>> +# generated links to keep implying the script name if it wasn't explicitly
>> +# indicated in the URL we're handling, but it means that $my_url cannot be used
>> +# as base URL. Therefore, we have to build the base URL ourselves:
>> +our $base_url = $cgi->url(-base => 1) . $ENV{'SCRIPT_NAME'};

Breaks t9500 with 

    [Sat Feb 14 02:12:59 2009] gitweb.perl: Use of uninitialized value in concatenation (.) or string at /pub/git/t/../gitweb/gitweb.perl line 45.

Please be more careful when giving an Ack, and more importantly please do
not send a patch that does not even pass the test suite by itself.